-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inheritance in L1MuonPixelTrackFitter and L1MuonRegionProducer #16492
Conversation
The only customer of L1MuonPixelTrackFitter is TSGFromL1Muon, which dynamic_casts the fitter to L1MuonPixelTrackFitter. The current code does not work unless the the fitter is of type L1MuonPixelTrackFitter, this commit makes this fact more explicit.
The only customer of L1MuonRegionProducer is TSGFromL1Muon, which dynamic_casts the region producer to L1MuonRegionProducer. The current code does not work unless the the region producer is of type L1MuonRegionProducer, this commit makes this fact more explicit.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: RecoMuon/TrackerSeedGenerator @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild ,please test |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 Code clean-up of unneeded inheritance in L1MuonPixelTrackFitter and L1MuonRegionProducer. There should be no change in monitored quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-11-08-1100 show no significant differences, as expected. |
did the bot fall asleep? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
While refactoring
PixelTrackProducer
, it occurred to me that for regions and fitterTSGFromL1Muon
uses onlyL1MuonRegionProducer
andL1MuonPixelTrackFitter
(with an explicitdynamic_cast
in the code and without failure check). Furthermore, these two classes are used only byTSGFromL1Muon
. Therefore, for current use cases, there is no need forL1MuonRegionProducer
to inherit fromTrackingRegionProducer
, andL1MuonPixelTrackFitter
fromPixelFitter
. This PR suggests to remove those inheritances to ease a bit further refactoring elsewhere.Tested in CMSSW_8_1_0_pre16, no changes expected in results.
@rovere @VinInn